New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bitwise NOT operator #18
Conversation
Thanks so much for contributing! I'm really ecstatic to see the first code contribution to pytago. Would you mind adding a simple test case for this in the If you create a new file (instead of adding to an existing one), you'd need to reference it from It doesn't have to be a new test case, you could just add something to the input and output of an existing |
Well I tried to do that. bitwisenot.py
bitwise.go
generate_scripts.py gives this error:
Weirdly enough, I modified the script to print file names and it seems that it actually stops at listappend...?
|
The filenames should be the same other than the extensions, maybe that's what's wrong here? I see you have EDIT: Nevermind, I see in the PR you actually did it right (in terms of filenames), just in your message you wrote different names. I will take a look at this ASAP to see if I can figure out what's going on -- hopefully I'll find time late this evening after the Lion King musical :P EDIT 2: Oh, I think you need to add the test to pytago/tests/test_core.py? I'm not sure if that's the entire issue but it should be there. |
That was the issue yes. |
Looks good to me! Thanks so much for the contribution! |
Python has
~0x3
, which upon research and testing shows that this is basically the same result as Golang's "^0x3".This adds support for that.