Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Broken phpseclib/phpseclib dependency #24

Closed
jaimeperez opened this issue Aug 4, 2015 · 3 comments
Closed

Broken phpseclib/phpseclib dependency #24

jaimeperez opened this issue Aug 4, 2015 · 3 comments

Comments

@jaimeperez
Copy link

Hi!

The dependency on phpseclib/phpseclib is broken. They have just released 1.0.0 (which is fine), but also 2.0.0, which introduces namespaces and therefore breaks the jose library as it doesn't use namespaces for this dependency.

We've tested with 1.0.0 and it apparently works fine, so I would suggest changing the dependency to (but you may want to check that actually everything is working for you):

    "phpseclib/phpseclib": ">=0.3.5 <2.0.0"

I'd say it's quite urgent, since at the moment the library is completely broken for new installations.

Thanks!

@nov
Copy link
Owner

nov commented Aug 10, 2015

OK, I'll release with your quick fix for now.
And also it's probably good timing to remove php5.2 support and start using phpseclib 2.0+.

@nov
Copy link
Owner

nov commented Aug 10, 2015

this pull request limits phpseclib version between 0.3.5 and 0.3.10.
#26

ps.
1.0.0 also has an issue which changes JOSE_JWS behaviour.
phpseclib/phpseclib#768

@nov nov closed this as completed Aug 10, 2015
@jaimeperez
Copy link
Author

Good that you were able to spot the problem with 1.0.0. Thanks for solving this, Nov!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants