Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-jwt allows bypass of identity checks via a sign/encryption #120

Closed
Shoaib19 opened this issue Mar 4, 2024 · 7 comments
Closed

json-jwt allows bypass of identity checks via a sign/encryption #120

Shoaib19 opened this issue Mar 4, 2024 · 7 comments

Comments

@Shoaib19
Copy link

Shoaib19 commented Mar 4, 2024

I am getting the error is it resolved in 1.16.6?

The json-jwt (aka JSON::JWT) gem versions 1.16.5 and below sometimes allows bypass of identity checks via a sign/encryption confusion attack. For example, JWE can sometimes be used to bypass
JSON::JWT.decode.

@bramn
Copy link

bramn commented Mar 4, 2024

Not according to bundle-audit:

ruby-advisory-db:
  advisories:	877 advisories
  last updated:	2024-03-02 13:38:12 -0800
  commit:	973ee9391883d41454c48851116c774f1bfc78c8
Name: json-jwt
Version: 1.16.6
CVE: CVE-2023-51774
GHSA: GHSA-c8v6-786g-vjx6
Criticality: Unknown
URL: https://github.com/P3ngu1nW/CVE_Request/blob/main/novjson-jwt.md
Title: json-jwt allows bypass of identity checks via a sign/encryption confusion attack
Solution: remove or disable this gem until a patch is available!```

@nov
Copy link
Owner

nov commented Mar 4, 2024

#118 (comment)

@Shoaib19
Copy link
Author

Shoaib19 commented Mar 4, 2024

@nov Yeah I see but the bundle audit still producing the warning CI run it for verification, can you also fix that?

@nov
Copy link
Owner

nov commented Mar 4, 2024

I have no idea how to fix that.

@annettemccullough
Copy link

Has v1.16.6 be released, I don't see it in https://github.com/nov/json-jwt/releases

@Shoaib19
Copy link
Author

Shoaib19 commented Mar 4, 2024

@annettemccullough here it is
https://rubygems.org/gems/json-jwt/versions/1.16.6

@Shoaib19
Copy link
Author

Shoaib19 commented Mar 5, 2024

The issue has been resolved by this PR #3876
just need to update the gem to 1.16.6 or later.

@Shoaib19 Shoaib19 closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants