Fix Rubocop triggering when disabled #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where Rubocop autocorrection will run even when disabled. `SETTINGS.rubocop.autocorrectOnSave()` will return a string. When the 'Disabled' option is select in the settings, this method returns the string 'Disabled' which is a truthy value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Rubocop autocorrection will run even when disabled.
SETTINGS.rubocop.autocorrectOnSave()will return a string. When the 'Disabled' option is selected in the settings, this method returns the string 'Disabled' which is a truthy value.We explicitly check the return value of
autocorrectOnSave()to determine if we should bind theonDidSaveevent handler to the active text editor.Fixes #29