-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Libraries getting lost on Amazon Fire devices #844
Comments
It seems that your problem is not fire device specific but most probably linked to time capsule SMB1 server since it works on my side on a Synology NAS. |
I've seen this too on my Fire TV 4K stick, but it never happens on my most used device, the Onn 4K. The person using it complains that the "movies are gone" and I have to revert everything back to normal. It's happened...probably 3 times in the past year? I'm using a Windows PC as a Samba server aka my main office PC, and it provides the video for all the screens in the house. |
The curious thing about this is that it happens on the Firecube using v6.0.97. I have reverted to every version until v6.0.67, where it does not happen (which, to my mind, discards the Time Capsule as the culprit). Same thing happens with the Firestick 4K Max, except that v6.0.67 happens sporadically on that one. I'm just guessing here, but I think it has more to do with Nova's database than the Time Capsule... Also, this happens every single time I repeat the steps in the original post, no matter if it's 2-3 minutes apart or 1-2 hours, etc., it happens all the same. |
OK I will test. And thanks for pointing out that this would be a regression after v6.0.67. I will check all the code modifications. |
Thanks. If you need logs or anything and point me out how to go about getting them, I'd be happy to help. I can also post a (private) video (on Youtube or whatever) to show you what's going on, if it helps. |
@Molasar49, is this correct to say that you do not have the problem on all your fire devices with v6.0.64? |
@courville I installed v6.0.65-20220508 on Firestick 4K Max, but it showed artifacts during playback, so I uninstalled (before checking the issue posted above) and reinstalled v6.0.67-20220605. This version shows the issue posted above. I tried v6.0.71-20220623 and v6.0.97 (the one you sent me previously and also downloaded from the App Store) and they all show the same issue (on the Firestick 4K Max). I went as far as restoring to factory settings, updating the OS and ONLY installing those Nova versions, and same problem persists. So I headed over to the FireCube 4K Gen2 and notice that only v6.0.67 works correctly - all newer versions show the same behavior. When launching on FireCube, v6.0.67 shows generic Movies and TV Shows icons but immediately recovers (split-second later), showing "customized" icons before I get a chance to do anything and all works fine. I don't know why v6.0.67 works on FireCube but not on Firestick Max. With Firestick, I sometimes get a Recently Played movie, which plays fine, but going into 'Movies', the library is empty - which makes me think it's not an SMBv1 or Time Capsule issue, but a Nova database issue - just my (educated) guess (since I used to be a full-time .NET developer). I was meaning to copy some of my movies from the Time Capsule to a Windows Server share and observe the behavior. Would that help in some way? What is strange (on Firestick) is that launching shows the behavior, returning to Home (OS) and relaunching seems to make Nova recover and populate library. Returning to Home (OS) and relaunching shows the issue, etc., etc. Going back and forth populates, then empty, then populated, then empty, etc. There seems to be no scanning involved - it's just as if it reads it's database, then it doesn't, then it reads it, then it doesn't, etc. (just guessing here). There is hardly any delay. It's just there or it isn't (if that makes any sense). |
Thanks for the detailed behavior analysis. I ruled out the SMB1 timecapsule issue. What I propose since you have the issue systematically, is to stick with latest release and try to get logs. I will share shortly a debug build with more logs around nova db and scraping. If you can capture adb logs with this release it would help (https://github.com/nova-video-player/aos-AVP/wiki/Debugging, adb connect adb logcat etc...). |
@courville, So, you recommend I uninstall v6.0.67 and install v6.0.97 on Firestick Max and capture logs, or wait until the debug build? |
@Molasar49 please use this build: https://drive.google.com/file/d/1-HoPfztgctk7Kro1lHJt1dY-W5MxWYai/view?usp=sharing |
@courville Ok, will proceed with this right now. And on the contrary, thank you for your time and effort! |
Do not hesitate to request help. |
@courville Wow! This version works! The only thing I notice is that it's displaying generic Movies and TV Shows icons (after successful full scan), other than that, works as expected. I captured the logs. Do you wish me to send them over? |
Oh wait! When I disconnected adb, same problem!!!! |
Capturing new log right now. Recently Played shows 1 movie and it plays correctly. Libraries are empty. After a few minutes, Recently Added and Recently Played are gone too, but now showing populated libraries (and generic icons). Will play around a bit and send over logs. |
Damn, yes please send the logs and I will analyze tomorrow. |
@courville Done. Also sent a link on the email to a video capture with my phone showing the issue. Hope it helps. |
Thanks for taking the time to investigate and for sharing the logs and the media dbs at different stages and an explanatory video. |
I will revert the changes made around the 6.0.67 and share a new build with you tonight. I will add logs only on these parts and I will kindly request that you capture logs from nova only via for linux/macos |
Thanks. Will be away for Sabbath but will continue after that. Thanks again! |
@Molasar49, I will share an experimental build soon for you to test. What is not entirely logic on my side looking at the code changes is that you state that it works with v6.0.67 but not with v6.0.68. Do you confirm this statement? |
OK re-reading the full thread, issue happens with v6.0.67 but less frequently but not with v6.0.65. It is thus between v6.0.65 and v6.0.67 that the issue has been introduced and it far more visible after v6.0.67. |
Note to self: might be related to #141, #605, #134 (check with in Video
Github releases dates:
Comment: AsyncTaskLoader relies on ModernTaskLoader now and uses |
@Molasar49 could you please test this new build and report if it is any better https://drive.google.com/file/d/1-HoPfztgctk7Kro1lHJt1dY-W5MxWYai/view?usp=sharing ? It has VideoLoader throttling enabled for all related loaders and relies on |
@Molasar49 after and only after testing above build, if it is still nok, it would be nice if you could provide feedback on this build where the default android |
Can confirm: With "flash cycles" (totally unnatural), I can consistently get generic library icons. However, all else is correct. Just my opinion this is not a flaw, as a "flash cycle" is nothing short of unnatural. Even a near 0.5s cycle causes no problems (i.e.: restores icons to customized). |
Thus it means that somehow my last change makes the worst build (TEST5) stable for the 'library not populated' issue. For the generic icon issue: I will work on it on the next step. For now I made the app recover when crashing during buildAllMoviesBoxTask and I have a design issue regarding icons not generated after first scrap. Anyhow, this would be a fantastic progress if you do not get anymore the 'library not populated' issue. |
Up to this point, no matter what I threw at it (including flash cycles), I could NOT get it to fail (i.e.: empty libraries)... Will continue a bit more cycles and then proceed to set "Re-scan on app start" to Yes, and continue tests. If it succeeds, will test TEST8 on Firestick 4K Max. |
If it works, it means that in reality the global issue is a huge race condition which frequency of occurence is influenced by the loaders strategy but not linked to the loaders itself. I will thus revert the original strategy for better efficiency. Note that I can reproduce the generic box icons: easier then to fix. Thanks again for all the effort in thorough testing! |
Happy to report TEST8 is a winner on Firecube 4K Gen2 Wired with Re-scan on app startup set to "No". Will now set to "Yes" and continue tests... |
Extremely happy to report TEST8 is a WINNER on Firecube 4K Gen2 Wired! Could not make it lose libraries no matter what I threw at it (including using Home key instead of Return, randomly). Works as expected. Will run TEST8 trials on Firestick 4K Max Wifi after lunch and report back. |
TEST9 should now always build iconBoxes except for initial first scraping at first install (otherwise it is the same as TEST8). |
@courville About to initiate tests (TEST8) on Firestick. Do you wish me to continue, or jump right into TEST9 (on Firecube, etc.)? |
@Molasar49 just finish TEST8 (pretty please) and then you can take TEST9 for your everyday use. |
@courville Gotcha. Initiating now... |
TEST8 (on Firestick 4K Max Wifi) Note: Will assume generic library icons on initial scan finish is correct behavior and should regenerate on first cycle.
Initiating random cycles... (all cycles using "Return" and "Select/Enter" key on remote). Firestick is 12ft. aprox away from AP, clear line of sight. AP is wired to unmanaged switch, wired to managed switch, wired to Time Capsule, all 1Gb (ethernet wired) speed. |
Just failed again...
|
Just for the sake of completeness, checked Network stats (OS). Shows: Frequency: 5220MHz Ran integrated OS speed test. Shows: Continuing with tests... |
Since Recently Added is populated, picked a random title, and it played correctly. However, on return, Recently Played is still gone... |
@courville This is clearly failing (easily) on Firestick 4K Max. What do you wish me to do? |
Rebooting AP and managed switch for the sake of completeness and continue test. Will report back. |
Rebooted Firestick last. Cycles in progress... looks promising... Whoops... just failed again :( Also, sometimes still losing Recently Added and Recently Played. Just hit another fail (empty libraries) after a random 8s-ish pause. Yet another fail (empty libraries) after random (20s-ish) cycle... TEST8 is definitely a no-go on Firestick 4K Max Wifi... :( After another random cycle, libraries icons customized and both libraries populated, but both Recents gone, which (to my mind at least) should rule out connectivity issues. Any movie plays fine. When both libraries are empty but Recents are populated, any title from Recents also plays fine. Would I be correct to assume this (not a connectivity or SMB issue)? |
Again, for the sake of completeness, uninstalled TEST8 and installed TEST3 (without rebooting) - Firestick 4K Max. After 1 hour of intense, UNRELENTING POUNDING (well beyond the scope of normal use), I did manage to make it fail about 4 times, but it was VERY hard to do so... Going to extremes, have relocated Firestick to a location where I can use the ethernet adapter (included) and wire it to the same switch where the Firecube is connected. Wifi is now turned OFF. Using a computer monitor (HP) as test screen. Will reinitiate TEST8 tests and report back... |
TEST8 (on Firestick 4K Max Wired) Note: Will assume generic library icons on initial scan finish is correct behavior and should regenerate on first cycle.
Can definitely say without any further tests that the above results pretty much discard wifi issues as the Firestick is now ethernet wired to the same (unmanaged) 100Mbps switch as the Firecube 4K Gen2. |
@courville I think this shows (sufficient) erratic behavior on Firestick 4K Max Wired (discarding wifi issues) to be declared a definite fail for TEST8. I have no idea why the difference in behavior between Cube and Stick... Please let me know if you wish any other tests, etc. |
Switched to another port on the Dell ethernet switch (as I just saw the SPD/LNK/ACT LED -maybe- a bit dimmed on the previous port). Both SPD/LNK/ACT (blinking) and FDX/HDX LEDs fully bright. Continuing tests...
|
Well, that was short-lived. Just got it to fail after a random pause.
I think we can safely assume the observed failures are not wifi related (or even connectivity related), nor even Apple Time Capsule (sleeping) related, as TEST8 does not fail on Firecube. I didn't POUND it (TEST8) relentlessly on the Cube, but I can if you want to. Please let me know. As a note, these latter (wired) tests weren't merciless either; about the same as on the Cube. I am now moving the Stick back to its original place (wifi). |
Hi, thanks again for all the tests, even if this is disappointing. Thus conclusion is that all the releases are failing ultimately even the best of all TEST3 :-(
At this point, I would be tempted to comply and try out the proposed |
@courville Yes, I reinstalled TEST3 on Firestick (while it was still wired) and I made it fail quite frequently with just a bit of trying... :( I don't know why it's that much more noticeable on the Stick than on the Cube... Maybe because the hardware is more capable or faster on the Cube... no idea... |
@Molasar49 thanks for the confirmation of my hunch. I guess the difference of behavior is linked to a core race condition that is indeed put in evidence depending on the hardware capabilities and patterns. |
Since this is not a loader issue: get safely back to
Conclusion: one could benefit of multithread but since a long |
@Molasar49 has this issue been resolved for you? |
Have done no tests on any newer versions as it was my understanding that this wasn't getting fixed any time soon (i.e., there was no indication to test out any newer versions). I am still on version v6.1.3 (20230327.1852). Have not updated to any newer version. I had a sense that the issue would be addressed much later (since it appears to involve a lot of rework). Has anything changed regarding this issue in later versions? Will be happy to test. |
Problem description
After initial scraping (SMBv1 share on Apple Time Capsule), both Movies and TV Shows display correctly. However, if browsing another app on the Fire device and returning to Nova Player, libraries are gone. I have to exit Nova or press 'Home', wait a couple of minutes, then launch Nova again, and the libraries will appear again. 'Recently Played' and 'Recently Added' also sometimes appear, sometimes disappear.
v6.0.67 was the last version to work correctly on FireCube 4K Gen2.
v6.0.65 and above work inconsistently on FireStick 4K Max.
Have done a complete factory reset on the FireStick 4K Max, and clean-installed Nova (v6.0.65 and above) and same problem.
Steps to reproduce the issue
At this point, Movies and TV Shows display generic icons and no movies or tv shows appear.
At this point, Movies and TV Shows display populated icons and movies and tv shows fully appear.
If I repeat the same steps again (exit, wait, launch), then libraries are gone again, etc., etc. This behavior cycles.
I have changed Initial Scan on App Startup on and off to no effect.
Cleared cache and data to no avail.
Expected behavior
Libraries should stay populated.
Your phone/tablet/androidTV model
Firecube 4K Gen2, Firestick 4k Max
Operating system version
Fire OS 7.6.2.4
Application version and app store
v6.0.97 from Amazon App Store
Additional system information
v6.0.67 was the last version to work correctly on FireCube 4K Gen2.
v6.0.65 and above work inconsistently on FireStick 4K Max. Haven't tried earlier versions.
Debug logs
No response
The text was updated successfully, but these errors were encountered: