Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Android Studio Electric Eel support #3

Open
jmalfara opened this issue Sep 27, 2022 · 0 comments
Open

Android Studio Electric Eel support #3

jmalfara opened this issue Sep 27, 2022 · 0 comments

Comments

@jmalfara
Copy link

jmalfara commented Sep 27, 2022

Hey folks.

I wanted to mess around with substrate for a personal project and figured this was a good place to start.
I noticed the AGP and kotlin versions are a bit out of date.

I have a fork with the changes needed to run with EE. Are PR's accepted here?
https://github.com/jmalfara/nova-android-app/pull/2/files

There aren't too many changes but i'd love to contribute back to this community.
Its also very lightly tested and I'm seeing a room test fail, but only when running it via studio. CLI seems fine with ./gradlew test
(Some insight would be helpful, i'm not very familiar with Room)

Seems to be missing migrations (?)

java.lang.IllegalStateException: A migration from 9 to 13 was required but not found. Please provide the necessary Migration path via RoomDatabase.Builder.addMigration(Migration ...) or allow for destructive migrations via one of the RoomDatabase.Builder.fallbackToDestructiveMigration* methods.
at androidx.room.RoomOpenHelper.onUpgrade(RoomOpenHelper.java:117)
at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onUpgrade(FrameworkSQLiteOpenHelper.java:183)
at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:416)
at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:316)
at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableSupportDatabase(FrameworkSQLiteOpenHelper.java:151)
at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.java:112)
at androidx.room.RoomDatabase.inTransaction(RoomDatabase.java:706)
at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.java:483)
at androidx.room.RoomDatabase.query(RoomDatabase.java:526)
at androidx.room.util.DBUtil.query(DBUtil.java:86)
at io.novafoundation.nova.core_db.dao.AssetDao_Impl$4.call(AssetDao_Impl.java:281)

Edit: There are a few other things that should be done but figured it would be a bigger change than an introduction PR should be.

  • Removing Synthetics from the staking module
  • Bumping all the dependencies up
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant