-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js-temporal.js 'GetFormatterParts' broken in Firefox 96.0 and Chromium 96.0.4664.110... #114
Comments
Some additional information... It's complaining that the variable 'time' doesn't exist. Ignoring the existential, it's clearly defined around line 8474, but I wonder if there's some update to JavaScript that doesn't like the syntax you're using there. |
Oh no, it's much worse than I thought... All of your widgets for handling dates and times are impacted by this, likely because you're using that same function everywhere. |
Ah, it's the temporal polyfill that has the bug and you've inherited it. Gads. This is going to impact a lot of libraries. |
I'll submit a bug-fix to your dependency. Sorry for the trouble, but at least you're now aware of it, heh. |
Ah, no maybe you need an update: |
Thanks for the report! I actually ran into this issue while working on the upcoming stylesheet rework. And tested the newer
A workaround seemed to be explicitly only use the ISO-8601 calendar, but then the components wouldn't automatically inherit the user's defaults. So I'm going to have to look into it a bit more. |
Yeah, I noticed that the polyfill created breaking changes between 0.2.x and 0.3.x, which is a tad frustrating, as it prevents you from easily providing a 0.5.3 update. For now, for my project, I've gone to using something else that isn't quite as nice. |
Fixed in |
Describe the Bug
Use of the DayStepper widget will cause your application to fail (not render) in newer versions of Firefox and Chromium (presumably Chrome as well, possibly also the myriad of other browsers using that engine). Note that it does work in Firefox 95.0.2.
You may get a stack trace similar to this:
Reproduction
Import DayStepper from 0.5.2 of @kahi-ui/framework.
Use it, binding 'value' to a variable.
System Info
System: OS: Linux 5.10 Manjaro Linux CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor Memory: 543.38 MB / 15.60 GB Container: Yes Shell: 5.1.12 - /bin/bash Binaries: Node: 17.3.0 - /usr/bin/node Yarn: 1.22.17 - /usr/bin/yarn npm: 8.3.0 - /usr/bin/npm Browsers: Chromium: 96.0.4664.110 Firefox: 96.0 Note: Also saw this issue in macOS 12.1, but not on Safari 15.2.
Additional Context
No response
The text was updated successfully, but these errors were encountered: