Fix URL for accessing the API of a build

At some point between Jenkins 2.52 and 2.59, the URL returned at job
creation by jenkins changed from the url of the job to that url suffixed
with /display/redirect. When suffixing all that with /api/python, the
api part is ignored. This commit removes the /display/redirect just
before using it.

jenkins_epo/jenkins.py

@@ -180,6 +180,9 @@ def from_url(cls, url):
         if not url.startswith(SETTINGS.JENKINS_URL):
             raise NotOnJenkins("%s is not on this Jenkins." % url)
 
+        if url.endswith("/display/redirect"):
+            url = url.replace("/display/redirect", "")
+
         payload = yield from rest.Client(url).api.python.aget(
             tree=cls.jenkins_tree,
         )

tests/test_jenkins.py

@@ -481,3 +481,23 @@ def test_job_updated_at(JobSpec):
 
     job = Job(Mock(_data=dict(description="""no yaml""")))
     assert not job.updated_at
+
+
+@pytest.mark.asyncio
+@asyncio.coroutine
+def test_from_url_removes_suffix(mocker, SETTINGS):
+    from jenkins_epo.jenkins import Build
+    Client = mocker.patch('jenkins_epo.jenkins.rest.Client')
+    Client().api.python.aget = aget = CoroutineMock(
+        return_value={}
+    )
+    SETTINGS.JENKINS_URL = "http://jenkins.local"
+    url = SETTINGS.JENKINS_URL + "/job/rh2-build-doc/4910/display/redirect"
+    correct_url = SETTINGS.JENKINS_URL + "/job/rh2-build-doc/4910"
+
+    build = yield from Build.from_url(url)
+
+    assert isinstance(build, Build)
+    assert build.job is None
+    assert build.payload == {}
+    assert Client.mock_calls[1] == mocker.call(correct_url)