Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file format for import/export dynamic derivations #1839

Closed
pgolovkin opened this issue Jun 6, 2024 · 4 comments · Fixed by #1872
Closed

Update file format for import/export dynamic derivations #1839

pgolovkin opened this issue Jun 6, 2024 · 4 comments · Fixed by #1872
Assignees

Comments

@pgolovkin
Copy link
Collaborator

pgolovkin commented Jun 6, 2024

Proposed format

version: 1
//polkadot: "Main" [main]
//polkadot//staking: "staking" [custom]
//polkadot//governance: "governance" [custom]
//polkadot//governance//0...20: anonymous

DOD:

  1. Keep backward compatability with yml file
  2. Update UI (removing the only yml format support)
  3. Update the logic for importing file
  4. Update the logic for exporting file
@pgolovkin pgolovkin assigned pgolovkin and sokolova-an and unassigned pgolovkin Jun 6, 2024
@sokolova-an
Copy link
Contributor

structure txt file

version: 1
vault public address: {public_address}
{derivation_path}//0...{sharded}: "{name}" [{type}] ({genesis_hash})

example:

version: 1
vault public address: 0x387aed21a43ed189c8f0d14aab6f05f715f1adfe670efa6090208ddd4efe991f
//polkadot: "Main" [main] (0x91b171bb158e2d3848fa23a9f1c25182fb8e20313b2c1eb49219da7a70ce90c3)
//polkadot//pub: "Pub account" [pub] 
//kusama: "Main" [main] (0xb0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe)
//kusama//custom//0..5: "shard acc" [custom] 

example 2:

version: 1
vault public address: 0x387aed21a43ed189c8f0d14aab6f05f715f1adfe670efa6090208ddd4efe991f
hash - 0x91b171bb158e2d3848fa23a9f1c25182fb8e20313b2c1eb49219da7a70ce90c3:
//polkadot: "Main" [main] 
//polkadot//pub: "Pub account" [pub] 
hash - 0xb0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe:
//kusama: "Main" [main] 
//kusama//custom//0..5: "shard acc" [custom] 

@pgolovkin
Copy link
Collaborator Author

Let's use example 2 format for now.

@sokolova-an sokolova-an linked a pull request Jun 17, 2024 that will close this issue
@stepanLav
Copy link
Member

Status verification: ❌

What has been verified:

@stepanLav
Copy link
Member

Status verification: ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants