Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical vulnerability in v1.2.0 #274

Closed
vdhanan opened this issue Apr 27, 2022 · 7 comments
Closed

Critical vulnerability in v1.2.0 #274

vdhanan opened this issue Apr 27, 2022 · 7 comments

Comments

@vdhanan
Copy link

vdhanan commented Apr 27, 2022

opaque-ke 1.2.0 depends on curve25519-dalek 3, which in turn depends on rand_core 0.5.1. This version of rand_core has a critical bug. I think we can fix this by patching v1.2 of opaque-ke to use the same version of curve25519-dalek that is used on master. Thoughts?

@vdhanan
Copy link
Author

vdhanan commented Apr 27, 2022

Link to our Dependabot alert: https://github.com/CommE2E/comm/security/dependabot/76

@kevinlewi
Copy link
Contributor

kevinlewi commented Apr 28, 2022

@vdhanan: The link you provided above returns a 404 for me. Can you provide a new one, or one for the critical bug in rand_core?

@vdhanan
Copy link
Author

vdhanan commented Apr 28, 2022

@kevinlewi sorry about that! here's a screenshot: Screen Shot 2022-04-27 at 9 10 31 PM

@vdhanan
Copy link
Author

vdhanan commented Apr 28, 2022

@kevinlewi
Copy link
Contributor

From https://nvd.nist.gov/vuln/detail/CVE-2021-27378 ,

From (including)0.6.0 | Up to (excluding)0.6.2

So it looks like rand_core v0.5 is unaffected. This also matches what I expected see on crates.io for the package, https://crates.io/crates/rand_core/versions (versions 0.6.0 and 0.6.1 were yanked, but 0.5.1 is still up)

@kevinlewi
Copy link
Contributor

Closing as this is not a vulnerability (but feel free to reopen if you think there is more discussion to be had...!)

@vdhanan
Copy link
Author

vdhanan commented Apr 28, 2022

Looks like dependabot was wrong! Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants