Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

novnc stopped working with HTTP authentication in Chromium #919

Closed
khimaros opened this issue Oct 7, 2017 · 3 comments
Closed

novnc stopped working with HTTP authentication in Chromium #919

khimaros opened this issue Oct 7, 2017 · 3 comments

Comments

@khimaros
Copy link

khimaros commented Oct 7, 2017

I'm now receiving 401 authentication failures during module load in vnc_lite.html.

It seems like the likely root cause is: 14ecdc6

Does polyfill work with HTTP basic auth?

@khimaros khimaros changed the title novnc stopped working with HTTP authentication novnc stopped working with HTTP authentication in Chromium Oct 7, 2017
@khimaros
Copy link
Author

khimaros commented Oct 7, 2017

Changing the <script> tag to <script type="module" crossorigin="anonymous"> (adding the crossorigin attribute) fixes the issue for me. It's odd that this isn't the default, but there are a few places that confirm this is the intended behavior:

https://bugs.chromium.org/p/chromium/issues/detail?id=717525
https://jakearchibald.com/2017/es-modules-in-browsers/ (see the "No credentials" section)
whatwg/html#1888

@CendioOssman
Copy link
Member

Well, that seems to be not entirely intended and is apparently changing:

whatwg/html#2557
whatwg/fetch#585

However until this rolls out we probably need that workaround.

The polyfill uses XHR which has different behaviour, so it should work fine.

@CendioOssman
Copy link
Member

Fixed in bf82644. Thanks for reporting and debugging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants