Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get token #967

Closed
tpatil opened this issue Dec 5, 2017 · 3 comments
Closed

Unable to get token #967

tpatil opened this issue Dec 5, 2017 · 3 comments

Comments

@tpatil
Copy link

tpatil commented Dec 5, 2017

Environment:
noVNC=v1.0.0-testing.2
websockify=0.8.0

I'm using noVNC v1.0.0 in OpenStack nova environment to test QEMU RFB Extension (#596) using Japanese keyboard.

I tried to access vnc console using url "http://192.168.252.14:6080/vnc_auto.html?token=8cb819e5-5882-41c9-9ab3-17609160e6d0&title=nova(2ed16227-73a6-457a-8bc2-57ca2a41431c)", but in websockify proxy request handler [1], I don't get the token as query parameter as well as it is not set in cookie.

If I use noVNC 0.6.0, I get token as expected.

So I think there is some issue with passing token to websockify.

[1] : https://github.com/openstack/nova/blob/master/nova/console/websocketproxy.py#L122

@samhed
Copy link
Member

samhed commented Dec 5, 2017

Yes, the token setting was removed from master a year ago. It was merely an alternative way to modify path, you should use path instead. This should work for you:

http://192.168.252.14:6080/vnc_auto.html?path=websockify%26token%3D8cb819e5-5882-41c9-9ab3-17609160e6d0&title=nova(2ed16227-73a6-457a-8bc2-57ca2a41431c)

@samhed samhed closed this as completed Dec 5, 2017
@samhed samhed added this to the v1.0.0 milestone Dec 5, 2017
@tpatil
Copy link
Author

tpatil commented Dec 6, 2017

I have confirmed it works for me.
Thank you.

@samhed
Copy link
Member

samhed commented Dec 6, 2017

Good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants