Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies broken when JX packaging in Windows #5

Open
PhilTee opened this issue Feb 7, 2017 · 0 comments
Open

Dependencies broken when JX packaging in Windows #5

PhilTee opened this issue Feb 7, 2017 · 0 comments

Comments

@PhilTee
Copy link

PhilTee commented Feb 7, 2017

I've noticed that the npm package for websockify will no longer compile to a working Windows binary when using JXcore.
It seems that the ws npm package has recently been updated from 1.1.1 to 2.0.2, and this seems to break websockify.

I appreciate that this is an edge case, but was wondering if it was worth amending the dependencies in package.json from"ws": ">=0.4.27" to maybe "ws": "~1.1.1"?

For information, I was building the Windows binary as follows:
jx package websockify\websockify.js websockify_x86 --native

@samhed samhed transferred this issue from novnc/websockify Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant