Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Fix gradle error #65

Merged
merged 3 commits into from Nov 20, 2016
Merged

Fix gradle error #65

merged 3 commits into from Nov 20, 2016

Conversation

dnbit
Copy link
Contributor

@dnbit dnbit commented Nov 18, 2016

Problem
Gradle fails with the following error:

Gradle sync failed: Cannot access first() element from an empty List

Solution
This seems to be related a bintray-release issue that was resolved here.

Nevertheless the bintray-release used in the core project has not been updated. Using latest bintray-release version (0.4.0) solves the issue as expected.

@stefanhoth
Copy link
Contributor

Can one of the admins review this PR?

@frapontillo
Copy link
Contributor

Please test this.

@stefanhoth stefanhoth closed this Nov 18, 2016
@frapontillo frapontillo reopened this Nov 18, 2016
@stefanhoth
Copy link
Contributor

Can one of the admins review this PR?

@stefanhoth stefanhoth closed this Nov 18, 2016
@dnbit
Copy link
Contributor Author

dnbit commented Nov 18, 2016

Sorry guys, can you elaborate on this?

@frapontillo
Copy link
Contributor

@dnbit sorry, that was just a command to start the CI build 😄.
BTW it's weird, it doesn't crash on my machine. What task are you running?

@dnbit
Copy link
Contributor Author

dnbit commented Nov 18, 2016

@frapontillo thanks for the clarification. I was a bit confused.

I just wanted to try the library and a normal build/make project failed with the message I mentioned above. As I found that it was an old issue in bintray-release I updated it in the corresponding build.gradle file and, after sync, it built successfully. That's all.

@frapontillo
Copy link
Contributor

Cool, no problem!
Just so we're clear, it was only a temporary issue, right?

@dnbit
Copy link
Contributor Author

dnbit commented Nov 19, 2016

@frapontillo
If you do a fresh checkout and stuck to the old gradle version that is given, the project compiles without an issue.

If you update the gradle version the project does not compile.

It seems reasonable to think that:

  • It is expected that most users who check out the code will update their gradle version
  • An update in the gradle version should not stop the code from compiling
  • A user who checks out the code and see it does not compile is a sad user 😢
  • A closed PR is likely to be abandon and forgotten

@ouchadam
Copy link
Contributor

really sorry about this @dnbit totally our fault! the ci node that this pr was being checked against was using JDK7. Thanks for the changes, I'll make a note to update all our other library projects

@ouchadam ouchadam reopened this Nov 20, 2016
@stefanhoth
Copy link
Contributor

Can one of the admins review this PR?

@ouchadam ouchadam merged commit 694e1a0 into novoda:master Nov 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with gradle plugin 2.4
4 participants