Add chips demo #23
Merged
Add chips demo #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 1, 2016 12:25
- Make tags selectable - Use a different resource for selected tags - When the 'Enter' key is pressed add the text as a tag and don't hide the keyboard
|
|
||
| @Override | ||
| public void afterTextChanged(Editable s) { | ||
|
|
added 9 commits
August 4, 2016 17:40
|
Ready for a re-review 👀 @blundell @florianmski 🎉 |
|
|
||
| repositories { | ||
| maven { | ||
| url 'http://dl.bintray.com/novoda/maven' |
There was a problem hiding this comment.
temporary - waiting for the lib to be accepted in jcenter
There was a problem hiding this comment.
might be worth a code comment in case we forget 😄
There was a problem hiding this comment.
we've been accepted 🎉 will change
| @Override | ||
| protected void onTextChanged(Editable text) { | ||
| String rawText = text.toString(); | ||
| if (!textContainsHint(text) && (rawText.isEmpty() || containsSpansOnly(rawText))) { |
There was a problem hiding this comment.
can be simplified at all? in name
There was a problem hiding this comment.
👍 done in the last commit (or at least tried!)
|
legit 👍 |
| } | ||
|
|
||
| /** | ||
| * According to the documentation it's modifying the text from this method is an error so we don't need to worry. |
There was a problem hiding this comment.
Something seems wrong in the wording, same for above
|
Small nits otherwise LGTM 👍 |
|
Comments addressed! 🎉 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a demo showing how to implement a 'chips' view using 2 libraries: