Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

allow novoda's plugin to auto gpg signing on bintray #301

Closed
marandaneto opened this issue Nov 13, 2019 · 11 comments
Closed

allow novoda's plugin to auto gpg signing on bintray #301

marandaneto opened this issue Nov 13, 2019 · 11 comments

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Nov 13, 2019

bintray's plugin already enable us to do that, but novoda's plugin not yet, we basically can achieve that adding a single attribute called sign, I've have set the default as false, so no side-effects nor breaking changes.
sign being true will tell bintray to sign artifacts using your custom gpg keypair if you have set one or bintray's keypair if you have chosen to use theirs, this is an opt-in feature.

I've made a PR for that, but it's only to show how simply would be, no tests yet (by tests I mean unit-tests).
https://github.com/novoda/bintray-release/pull/300/files

I already have tested it and it works with this single change.

@bruno-garcia
Copy link

#300

@marandaneto
Copy link
Contributor Author

would it be possible to have an update here? at least if you all aim to have it as a feature, thanks.

@mr-archano
Copy link
Contributor

sorry @marandaneto I must have missed your PR, but I just took a look.

@mr-archano
Copy link
Contributor

PR merged, new snapshot with this change is released: https://bintray.com/novoda-oss/snapshots/bintray-release/develop-38

@mr-archano
Copy link
Contributor

I'm preparing the release for 0.9.2 in the meantime

@mr-archano
Copy link
Contributor

The PR is ready to go, I am waiting for an admin to take care of it (I am not part of the Novoda GitHub org anymore, sorry). That should be enough to release 0.9.2 in Bintray for everyone to use.

@marandaneto
Copy link
Contributor Author

@mr-archano sounds awesome, thanks a lot, looking forward to using it :)

@mr-archano
Copy link
Contributor

@marandaneto you could start using the snapshot if you like https://github.com/novoda/bintray-release/blob/master/README.md#snapshots
In the meantime I will ensure we can get a release as soon as possible.

@mr-archano
Copy link
Contributor

Released as part of 0.9.2: https://bintray.com/novoda-oss/maven/bintray-release/0.9.2

@marandaneto
Copy link
Contributor Author

@mr-archano you may have forgotten to create the GitHub release btw. Thanks again.

@mr-archano
Copy link
Contributor

Thanks for the reminder @marandaneto. Release created: https://github.com/novoda/bintray-release/releases/tag/0.9.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants