Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Make Violations class and reports more informative #219

Closed
maxbach opened this issue Nov 25, 2019 · 3 comments
Closed

Make Violations class and reports more informative #219

maxbach opened this issue Nov 25, 2019 · 3 comments
Labels

Comments

@maxbach
Copy link

maxbach commented Nov 25, 2019

There are should be more info in Violations. It should be added list of Errors and Warnings. Every warning and error has a description, type, file and line in file, where it is located. Then it will be possible to create custom reports. For example, create report to console or Logcat with list of errors and every error will have a link to code with error.

For example,
image

@mr-archano
Copy link
Contributor

Hi @maxbach, thanks for the suggestion but I am not sure this should be this tool behaviour. This plugin is simply configuring other plugins, each of them using different ways of identifying and reporting violations of different nature.
The value that this plugin wants to provide is not unified reporting, but rather:

  • out-of-the box support for Android projects
  • allow to run all the checks and decide what is an unacceptable TOTAL amount of violations

Providing what you are suggesting is definitely feasible but I believe that we should keep the detailed reporting to each tool (we still link the reports in our output).

@msal98
Copy link

msal98 commented Dec 11, 2019

I'm finding that if I use the Checkstyle plugin directly I see violations in the console (very helpful). However, through this plugin I'm only seeing a link to the report. Does this fall under the "making violations more informative", or is this worthy of it's own issue?

@tasomaniac
Copy link
Contributor

Hi, since static analysis plugin consolidates all results, it changes some console output settings. The reason is to make the console output shorter.

Can you try to configure the Checkstyle plugin to output more? You can try doing it in

staticAnalysis {
    checkstyle {
        showViolations = true
    } 
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants