Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

NoPlayer views #77

Closed
Mecharyry opened this issue Jul 27, 2017 · 2 comments
Closed

NoPlayer views #77

Mecharyry opened this issue Jul 27, 2017 · 2 comments
Labels
enhancement
Projects
Issue Tracker

Comments

@Mecharyry
Copy link
Contributor

Problem

Currently NoPlayerView relies on ExoPlayer view groups coupling NoPlayer to ExoPlayer. See layout for more information.

Potential Solution

We should have NoPlayer implementations of any views that the layout relies on and not be dependent on any views from an underlying Player.

Impact

We won't be coupled to ExoPlayer if we ever drop support for it. We have complete knowledge of the views in our domain.
@Mecharyry Mecharyry added this to To Do in Issue Tracker Aug 4, 2017
@ouchadam
Copy link
Contributor

to clarify the action for this issue, to include the AspectRatioFrameLayout in our library?

@Mecharyry
Copy link
Contributor Author

Yes,any view that is part of the exo-player package and does not belong to us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
Issue Tracker
To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ouchadam @Mecharyry @juankysoriano