Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: "credentials.senderName" is ignored in some providers #2225

Closed
2 tasks done
ArturHamannRonconi opened this issue Dec 7, 2022 · 0 comments 路 Fixed by #2226
Closed
2 tasks done

馃悰 Bug Report: "credentials.senderName" is ignored in some providers #2225

ArturHamannRonconi opened this issue Dec 7, 2022 · 0 comments 路 Fixed by #2226

Comments

@ArturHamannRonconi
Copy link
Contributor

ArturHamannRonconi commented Dec 7, 2022

馃摐 Description

As with the following issues there is an issue when trying to add a credentials.senderName to some providers.

One of the providers with this error that I noticed was AWS SES, I am also creating a pull request resolving this specific bug

Note: as soon as I finish the pull request, I will add its link here, based on the following pull request, I believe that you can do the same for other providers

馃憻 Reproduction steps

1 - Clone the application
2 - Execute the following commands to setup local

  • npm run setup:project
  • npm run start:api:dev
  • npm run start:web
    3 - Create an account
    4 - On the Integrations tab select AWS SES
    5 - Add the necessary information and the senderName you want
    6 - Create a template and with a trigger for an email
    7 - In the last step of editing the email template, test it by sending the email to yourself

馃憤 Expected behavior

The expected behavior is that the email is sent with the name chosen when creating the integration
Example:
Captura de tela de 2022-12-07 12-47-12

馃憥 Actual Behavior with Screenshots

What currently happens when the email is received it adds a name by default of 'no-reply'
Example:
Captura de tela de 2022-12-07 13-57-12

馃捇 Operating system

Linux

馃 Node Version

16.15.0

馃搩 Provide any additional context for the Bug.

Edit: 1 Here is the Pull request created

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants