Update email and In-app editor's height to sync it with the viewport height #4313
Conversation
There was a problem hiding this comment.
Hi @SmitDasadia , thanks for your contribution! Currently, it doesn't compile and does not solve the issue as it doesn't fix the actual height.
Please take another look :)
Also, if you could, its always helpful to add a screenshot of your result. We would appreciate it :)
| @@ -44,6 +44,7 @@ export function EmailCustomCodeEditor({ | |||
| }); | |||
|
|
|||
| return ( | |||
| <div sx={styledContainer}> | |||
There was a problem hiding this comment.
a div doe not have sx attribute, the sx is used by Mantine components. Your code will not compile.
| ); | ||
| } | ||
|
|
||
| const styledContainer = () => ({ | ||
| height: '80vh', // Adjust the percentage as needed |
There was a problem hiding this comment.
Setting a wrapper to be 80vh will not do the job, as the card itself -> the ace editor is set to a specific height (line 55). So what you did will simply result in the editor height being as it is now, unchanged, but will add a lot of empty page + scroll
github-actions
bot
added
stale
|
Closing due to inactivity |
What change does this PR introduce?
This PR update Email and In-app editor's height to sync it with the viewport height
Why was this change needed?
The change was to add div with sx={styledContainer} and contains height, overflow and marginBottom for email editor's, email custom code and In-app editor's height.
Fixes: #4244