Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2495] 🏘️ [Tenant] Tenant deletion UI action #4247

Open
LetItRock opened this issue Sep 30, 2023 · 7 comments
Open

[NV-2495] 🏘️ [Tenant] Tenant deletion UI action #4247

LetItRock opened this issue Sep 30, 2023 · 7 comments
Assignees

Comments

@LetItRock
Copy link
Contributor

What?

Tenant deletion action.

Note:

  • The tenancy feature is hidden behind the feature flag IS_MULTI_TENANCY_ENABLED. To enable this feature in the app you would need to hardcode the return value in the useIsMultiTenancyEnabled hook (don't commit this change).

Why? (Context)

Users need to have the ability to get rid of the tenants they no longer need or created by mistake

Definition of Done

  1. The delete icon is located near the "x-close" button on the panel of the update tenant sidebar
  2. The delete hint is displayed on hovering over the delete icon
  3. By clicking Delete:
  • Display warning modal with the warning message
  • Cancel will cancel the deletion and will close the pop-up window
  • The delete tenant button will hit the delete tenant endpoint
    • Show the hint: "The tenant @name is deleted"
    • UNDO button is displayed on the hint (out of scope)

Designs:
Tenant list / Delete tenant
Tenant list / Delete tenant
Tenant list / Delete tenant

@Substancia
Copy link

Hey there again @LetItRock , this looks interesting, can I work on this?

@AkshitSinghal224
Copy link

can you assign this to me i think i know that to do here

@LetItRock
Copy link
Contributor Author

hey @Substancia πŸ‘‹ you are assigned to another ticket about the tenancy, please complete that one first ;)

@TheNatkat the ticket is yours ;)

@Akash-152000
Copy link

hey @LetItRock can you please assign this issue to me, I would like work on it.

@LetItRock
Copy link
Contributor Author

hey @LetItRock can you please assign this issue to me, I would like work on it.

hey, @Akash-152000 πŸ‘‹ the ticket is already assigned to another person ;) please take a look at some other tickets we have :)

@AkshitSinghal224
Copy link

thanks for assign this ticket i will complete it in 24hr

@AkshitSinghal224
Copy link

@LetItRock i raised the pr if you want any changes feel free to tag me and also can you assign me another tenant issue i am sure i can i fix it thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants