Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain word generates error #49

Closed
Euramsia opened this issue May 23, 2021 · 3 comments
Closed

Certain word generates error #49

Euramsia opened this issue May 23, 2021 · 3 comments

Comments

@Euramsia
Copy link

When I used "Rest" (without quotation marks) as an end node, it scrambled the whole diagram in a weird way. It was definitely the word itself, the position in my list didn't make a difference, but once I changed one letter it worked normally.

Might be because Rest is some predefined function in JS or SVG or whatever.

@nowthis
Copy link
Owner

nowthis commented May 23, 2021

Odd, I wouldn't expect a specific word to cause an issue.

Can you attach the relevant portion of the text from the "Inputs" field?

This input works fine for me, for example:

A1 [100] B
A2 [200] B
B [300] Rest

Is it possible that 'Rest' is a name used already by another node earlier in the diagram?

(SankeyMATIC doesn't handle 'cycles' well currently, and trying to connect an later flow to an earlier node will definitely produce strange output.)

@Euramsia
Copy link
Author

Oh, yea, my bad. I checked and I used Rest twice, that's why it looked so twisted. Poor code went out of its way to make it work. Sorry for the disturbance.

@nowthis
Copy link
Owner

nowthis commented May 23, 2021

@Euramsia Not a problem. I think the tool could do a better job of alerting someone when that's happening. Thanks for reminding me about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants