Skip to content

Commit

Permalink
remove -r for checking SSL_{cert,key}_file since this will cause a us…
Browse files Browse the repository at this point in the history
…able error later anywy if file does not exist.

This fixes some part of #106295
  • Loading branch information
noxxi committed Aug 23, 2015
1 parent 6a98f0f commit 7432b34
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/IO/Socket/SSL.pm
Expand Up @@ -2082,7 +2082,6 @@ sub new {
defined( my $file = $arg_hash->{$_} ) or next;
for my $f (ref($file) eq 'HASH' ? values(%$file):$file ) {
die "$_ $f does not exist" if ! -f $f;
die "$_ $f is not accessible" if ! -r _;
}
}

Expand Down

2 comments on commit 7432b34

@michael-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at 421ac8e, shouldn't this be replaced like at the other commit instead of removed?

@noxxi
Copy link
Owner Author

@noxxi noxxi commented on 7432b34 Oct 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right in that it makes sense to check if the file can be opened. I've changed it in a97b5d3 accordingly.

Please sign in to comment.