Allow use of Organizational trail to be toggled via variable #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nozaq please let me know any feedback you have |
nozaq
reviewed
Feb 11, 2022
|
@nozaq unrelated - but I believe the terraform validate is failing bc of a new/updated s3 bucket module. I ran into something similar earlier this week. Let me know your thoughts |
nozaq
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Thanks for the quick update!
but I believe the terraform validate is failing bc of a new/updated s3 bucket module. I ran into something similar earlier this week.
Yeah, it looks like so. AWS provider has some breaking changes in v4.0. We can ignore the validation failure this time 👍🏼
|
@jamiedick LGTM, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.