Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageId in product variant not created or updated #50

Closed
ashishpathak2111 opened this issue May 3, 2016 · 3 comments
Closed

ImageId in product variant not created or updated #50

ashishpathak2111 opened this issue May 3, 2016 · 3 comments
Labels

Comments

@ashishpathak2111
Copy link

ImageId in product variant not created or updated

@nozzlegear nozzlegear added the bug label May 3, 2016
@nozzlegear
Copy link
Owner

Thanks for the report! I'll take a closer look at this as soon as possible.

@nozzlegear
Copy link
Owner

nozzlegear commented May 9, 2016

Alright, I've run some tests and confirmed that the ImageId doesn't get set in product variants, but right now I don't believe it's a problem with the library. I ran the same API calls manually through Fiddler and still couldn't get them to work. The only thing that did work was specifically creating a product image via the Product Image API and then using that image's id in the product variant. Nothing else would work, so I'm not sure if this is a bug on Shopify's end, or if it's an undocumented "feature".

Unfortunately there isn't a ProductImageService for ShopifySharp yet, but I've opened an issue to get it in soon.

All of that said, it could be that I missed something and there is in fact a bug in the lib, so if anybody else wants to take a crack at this I'd be happy to accept a pull request.

@bebecool
Copy link

bebecool commented Mar 21, 2019

still have trouble on product variant UpdateAsync ImageId
Worked in the past, but not now..

But ProductVariantService UpdateAsync ImageId still work. (just much call.. :p )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants