Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collects API doesn't support any longer. #565

Closed
tranquangkhai1996 opened this issue Aug 21, 2020 · 8 comments
Closed

Collects API doesn't support any longer. #565

tranquangkhai1996 opened this issue Aug 21, 2020 · 8 comments

Comments

@tranquangkhai1996
Copy link

Hi all,
I received an email about Migrating to the Collection endpoints. For details, from Oct 2020, the API /admin/collects doesn't support. And the new API /admin/collection will be used instead of that. How can I apply this change? Does the version ShopifySharp 5.2 support the API /admin/collection?
image

Follow this link:
https://shopify.dev/tutorials/migrate-from-collect-endpoint-to-collections

@nozzlegear
Copy link
Owner

The package does not currently support the new endpoint. I'm very far behind on the new Collections service, I don't use it personally so I haven't had much time to think about upgrading it. I'm planning to do some work on the project tomorrow evening and this weekend, I'll try to get the new endpoint implemented and published to Nuget.

@tranquangkhai1996
Copy link
Author

Does it support .NET Framework?

@tranquangkhai1996
Copy link
Author

Can I download your source codes in git and add the new Collections service?

@vinhch
Copy link

vinhch commented Aug 21, 2020

@tranquangkhai1996 You can do what ever you want. This library is under MIT license.

However, instead of add a new Collections service and uses it like a private version of this library, you could directly contribute to this repo (fork the code, update the new service and test cases, then make a pull request to this repo), that will help and share your work with other people.

Make it like a habit. Believe me it's a good habit ❤️

@tranquangkhai1996
Copy link
Author

@nozzlegear How can I set API Version in ShopifySharp dll? I saw that it only allow get.

@nozzlegear
Copy link
Owner

Hey @tranquangkhai1996, you can do this by overriding the Version property in a service class:

public class MyService : ShopifyService
{
    public MyService(string domain, string accessToken) : base(domain, accessToken) 
    {
    }

    public override string APIVersion => "2020-07";
}

@nozzlegear
Copy link
Owner

@tranquangkhai1996 Since we're running out of time to add support for this new endpoint, I went ahead and implemented the new CollectionService and published it to Nuget in version 5.5.0. If you update the package you should be able to use the new service in your project.

I do agree with @vinhch though, the whole package is MIT licensed and I greatly appreciate any help that developers offer with pull requests and contributions! Normally I'd let you or someone else implement this new service, but since I was working on the project tonight already and since this is time critical, I went ahead and did it myself this time.

@tranquangkhai1996
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants