Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Json.NET dependency to newer version #69

Closed
ghost opened this issue Sep 27, 2016 · 4 comments
Closed

Update Json.NET dependency to newer version #69

ghost opened this issue Sep 27, 2016 · 4 comments
Milestone

Comments

@ghost
Copy link

ghost commented Sep 27, 2016

This ShopifySharp library (btw, it's good and helpful, thank you) currently references Newtonsoft.Json v7.0 . It's kind of an old version (at this point 9.0.1 is up) and makes it impossible to use newer version of Json.NET if you add ShopifySharp as NuGet package. Maybe you can update Json.NET version dependency in future releases.

@ghost
Copy link
Author

ghost commented Sep 27, 2016

I just found out that you can actually specify version range in NuGet package dependency, so others can actually use newer versions of libraries even when other Nuget package that uses stops development.

http://stackoverflow.com/questions/7772346/how-to-specify-specific-dependency-version-in-nuspec

https://docs.nuget.org/ndocs/create-packages/dependency-versions

If you would specify version range for ShopifySharp dependencies - I'd be very glad. Thank you

@nozzlegear
Copy link
Owner

Thanks for the suggestion! I can't think of any problems with at least allowing a range of versions. I'll need to test it first, and if it all goes well I'll publish an update in the next week or so.

@ghost
Copy link
Author

ghost commented Sep 28, 2016

I haven't actually created Nuget package myself and not a Nuget expert, but it seems like you don't have dependency specified in nuspec at all, so it just expects Newtonsoft.Json.dll in bin directory with version specified in your lib project. And if it doesn't find needed version - it just breaks.
You need specify your external references in nuspec. If I'll have time I'll try to test it myself on this or next weekend.

@nozzlegear
Copy link
Owner

Newtonsoft.Json dependency has been updated to 10.0.1 in the 4.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant