-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add amazonec2 userdata
for docker machines
#608
Conversation
But I have no idea how to auto-generate README.md, I think this flag should be documented. (manually edit?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR! Just 2 little remarks.
…nto add-amazonec2-userdata
amazonec2 userdata
for docker machines
@npalm See my comment above. Better you check this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FelikZ thanks looks good! Please can you add the example. Which you mention in the PR to either the Readme. Or as comment in the default example. I would prefer the last one (example)
@npalm please have a look. Thanks |
Did you do a quick check without using the new variable |
Ok, it's working. Had a test environment available and deployed your changes. It is working without |
Description
Introducing support for amazonec2-userdata flag that is not mentioned on driver readme page, but it is there and useful.
For example, it can be used to introduce swap for the runner instance or any other user command.
Migrations required
NO - this is optional flag and defaults to empty string.
Verification
I have verified on my own runners cluster that user script that I've added works (it creates swap in my case).