Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suppress default tags from module #651

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Jan 9, 2023

Description

#413 describes the problem of interfering default_tags of the provider and the tags created by this module. Sometimes it is useful to skip the resource tagging by this module for certain tags.

This PR adds the ability to not add some/all of the default tags created by this module. Set suppressed_tags to a list of tags you want to suppress. It works for tags, runner_tags and agent_tags. role_tags are not modified as they are used in addition to tags.

Closes #413

Migrations required

No.

Verification

  • Deploy this version over the running version of the module. Make sure that the tags do not change.
  • Set suppressed_tags = ["Environment"]. Deploy the module over an already deployed module. Check the plan and make sure that the Environment tag is removed.

@kayman-mk kayman-mk marked this pull request as ready for review January 9, 2023 08:08
@kayman-mk kayman-mk requested a review from npalm as a code owner January 9, 2023 08:08
@kayman-mk kayman-mk changed the title feat: remove suppressed tags feat: suppress default tags from module Jan 10, 2023
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!, not tested

@kayman-mk kayman-mk merged commit 0021915 into cattle-ops:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to disable default tags
2 participants