This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: immediately poll when we load, don't stop polling on failure #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcoe
commented
May 17, 2016
•
bcoe
commented
- makes the integration feel more snappy.
- addresses an issue our integration partners were running into (an upstream failure would cause the integration to break).
| @@ -34,23 +34,23 @@ AnnotationPoller.prototype._installExtensions = function () { | |||
|
|
|||
| AnnotationPoller.prototype.start = function (loaded) { | |||
| var _this = this | |||
| var updating = false | |||
There was a problem hiding this comment.
Why remove the updating check? What happens if the interval runs while it's still waiting on a previous poll request?
|
How does this change the behavior when handling "an upstream failure"? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.