-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci.yml to send correct payload information to benchmark repo #3
Comments
Made the repo public. Still need to validate that the |
Situation
The dispatch endpoint is an authenticated endpoint, so you have to send a request that has a Personal Access Token (PAT) attached to it. The PAT needs to be from an account that has access to the repo, even though the repo is public. I suppose this makes sense otherwise anyone could trigger the events that you're repository is relying on. This does mean that only pull-requests that are opened in the SuggestionThis should be broken out into a separate ticket/story, for now. Making the repository public was the hypothesis to supporting community pull-requests. While not the case, this repository can (and should) still remain public. Possible SolutionA GitHub App that we own running on a server somewhere (heroku?), which does this dispatching for us. The |
fixed with npm/cli#689 |
Currently we have to run the following line to get the benchmark suite to work. The https://github.com/npm/cli repo has to send a request to this repository which is private, which means auth is needed.
https://github.com/npm/cli/blob/latest/.github/workflows/benchmark.yml#L38
Changing this repository to public should negate the need for auth. Allowing this request to just be sent.
Testing
curl
requestsThe text was updated successfully, but these errors were encountered: