Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only convert shebang CRs when converting CRLF to LF #2

Merged
merged 5 commits into from Mar 7, 2018
Merged

Only convert shebang CRs when converting CRLF to LF #2

merged 5 commits into from Mar 7, 2018

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Dec 4, 2017

Also switches to not using streams when doing our conversion.

@coveralls
Copy link

coveralls commented Dec 4, 2017 •
edited

Coverage Status

Coverage decreased (-2.5%) to 55.639% when pulling c1920af on limit-bin-remangling into 853497c on latest.

zkat
zkat approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my favorite part is that slide is gone

@zkat zkat merged commit 3185367 into latest Mar 7, 2018
@zkat zkat deleted the limit-bin-remangling branch March 7, 2018 21:52
zkat pushed a commit that referenced this pull request Mar 7, 2018
@iarna @zkat
fix(shebangs): only convert CR when doing CRLF -> LF (#2)
43bf857 
* Finish fully promisifying

* Cleanup isHashbangFile implementation

* Only do dos2unix pass when CRs are present in hashbang file

* Rewrite dos2unix to not use streams

* Only convert shebang CR when converting CRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarna @coveralls @zkat