cli,outdated: default homepage to an empty string #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch default package's homepage to an empty string in case the homepage isn't specificied in the package manifest. Before this patch, if at least one package didn't set an associated homepage, running npm outdated --long would break. After this patch, it won't display anything for this specific package Homepage row and it won't break for the other packages.
fharper
approved these changes
Dec 17, 2018
aeschright
pushed a commit
that referenced
this pull request
Jan 18, 2019
PR-URL: #124 Credit: @anchnk Reviewed-By: @aeschright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch default package's homepage to an empty string in case the
homepage isn't specificied in the package manifest.
Before this patch, if at least one package didn't set an associated
homepage, running npm outdated --long would break.
After this patch, it won't display anything for this specific package
Homepage row and it won't break for the other packages.