Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Turn auditing on for tertiary dependencies re: private dependencies #1304

Closed
mcandre opened this issue May 15, 2020 · 3 comments
Closed
Labels
Enhancement new feature or improvement

Comments

@mcandre
Copy link

mcandre commented May 15, 2020

What / Why

npm audit currently gets confused by package dependencies that are not on public NPM. This means any private wrapper libraries cause important security notices to go unseen, for the entire package subtree. Fortunately, relatively minor code changes could easily enable npm to audit these package trees as well.

Regardless of the source of the npm package, the target is always the local node_modules directory, complete with package.json details. So npm audit should in theory be able to add these entries to its scan list.

The vast majority of the package subtree should be auditable; Only the specific tree nodes off of public NPM registry would be ineligible for CVE reports.

@mcandre mcandre changed the title [FEATURE] Audit private dependencies [FEATURE] Turn auditing on for tertiary dependencies re: private dependencies May 15, 2020
@darcyclarke darcyclarke added the Enhancement new feature or improvement label Oct 30, 2020
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is reproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

@mcandre
Copy link
Author

mcandre commented Jun 2, 2021

Ongoing security attacks don't care about templates.

@ljharb
Copy link
Collaborator

ljharb commented Jun 2, 2021

@mcandre "audits" work serverside by looking at dependencies, so a private package indeed prevents any of its deps from being audited.

If you think there are indeed minor changes that would fix this, filing an RFC - which is not on this repo - would be appropriate.

Also, what "ongoing" security attacks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement
Projects
None yet
Development

No branches or pull requests

3 participants