Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Arborist for dedupe and prune #1395

Closed
wants to merge 4 commits into from
Closed

feat: use Arborist for dedupe and prune #1395

wants to merge 4 commits into from

Conversation

claudiahdz
Copy link
Contributor

@claudiahdz claudiahdz commented Jun 4, 2020 •
edited

This PR uses Arborist for dedupe and prune.

Dedupe docs have been updated to include the fact that npm find-dupes runs it in dryRun mode (which didn't seem to be documented anywhere).

@claudiahdz claudiahdz requested a review from a team as a code owner June 4, 2020 22:50
isaacs
isaacs reviewed Jun 4, 2020
View reviewed changes
lib/dedupe.js Show resolved Hide resolved
isaacs
isaacs reviewed Jun 4, 2020
View reviewed changes
lib/prune.js Show resolved Hide resolved
@claudiahdz
Copy link
Contributor Author

@isaacs! While adding dryRun for find-dupes, I noticed a regression here: e3e8c68#diff-59adaa9915a15ff8ed1f21fd655d5378L119

I could no longer get the aliased command from npm.command and had to make a small change that I hope does not impact other parts of the system.

@claudiahdz claudiahdz requested a review from ruyadorno June 8, 2020 22:12
@claudiahdz
Copy link
Contributor Author

As discussed with Isaac, find-dupes was decided to be made a top-level command.

ruyadorno
ruyadorno reviewed Jun 9, 2020
View reviewed changes
docs/content/cli-commands/npm-dedupe.md
@@ -60,6 +60,8 @@ Modules
Note that this operation transforms the dependency tree, but will never
result in new modules being installed.

Using `npm find-dupes` will run the command in dryRun mode.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh if npm find-dupes is now a top-level command it'd be nice to also add docs for it and a link below in the See Also section of this file 👇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about creating a new docs file for this command since it is essentially the same as dedupe only on dryRun mode. What do you think about just pointing the find-dupes docs to the dedupe docs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right! sounds good 👍

ruyadorno pushed a commit that referenced this pull request Jun 10, 2020
@claudiahdz @ruyadorno
feat: make find-dupes docs point to dedupe docs
2da5bfa 
PR-URL: #1395
Credit: @claudiahdz
Close: #1395
Reviewed-by: @ruyadorno
@ruyadorno
Copy link
Collaborator

merged 😄

@ruyadorno ruyadorno closed this Jun 10, 2020
@nlf nlf deleted the feat/dedupe-prune branch March 28, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacs isaacs isaacs left review comments

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@claudiahdz @ruyadorno @isaacs