Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(config): fix snapshot cleaner #3687

Merged
merged 1 commit into from Aug 26, 2021
Merged

Conversation

wraithgar
Copy link
Member

Order matters here so we clean the more specific things before the
generic ones.

@wraithgar wraithgar requested a review from a team as a code owner August 26, 2021 17:59
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is definitely correct

Order matters here so we clean the more specific things before the
generic ones.

PR-URL: #3687
Credit: @wraithgar
Close: #3687
Reviewed-by: @nlf
@wraithgar wraithgar merged commit 7af36bb into release-next Aug 26, 2021
@wraithgar wraithgar deleted the gar/config-tests branch August 26, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants