Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Workspaces peerDependencies not updated when using npm version #3885

Closed
1 task done
FreeFrags opened this issue Oct 13, 2021 · 3 comments
Closed
1 task done
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@FreeFrags
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Workspace
Package A

Package B
peerDependencies
Package A

I have the following situation, where Package B has a peerDependency of Package A.

I run npm version 1.2.3 --workspaces

Expected Behavior

I would expect:

  • The versions of Package A and Package B to be updated to 1.2.3
    This works as expected

  • The version of the Package A peerDependency in Package B to be updated to 1.2.3
    This doesn't work as expected

Steps To Reproduce

  1. Please see above

Environment

  • OS: Windows 10
  • Node: 16.8.0
  • npm: 7.21.0
@FreeFrags FreeFrags added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Oct 13, 2021
@FreeFrags
Copy link
Author

I think this is the same issue or is related to
#3403 (comment)

@ljharb
Copy link
Collaborator

ljharb commented Oct 13, 2021

Can you try with npm v7.24.2?

@wraithgar
Copy link
Member

Closing: this looks to be similar if not a duplicate of an existing issue, #3403. If you believe your instance is unique, please provide further clarifying details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

3 participants