chore(benchmark): add comment permission check and filter paths #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updates the issue comment check in the benchmark script, so it only will trigger if posted by a user with admin rights to the repo. It also changes the comment to trigger it to `@npm-robot benchmark this` For pull requests, it now limits benchmarks only when the files changed include something inside `lib/`. Requires npm/benchmarks#30 to be merged in the benchmark repo to allow `issue_comment` as a valid trigger.
ruyadorno
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates the issue comment check in the benchmark script, so it only
will trigger if posted by a user with admin rights to the repo. It also
changes the comment to trigger it to
@npm-robot benchmark thisFor pull requests, it now limits benchmarks only when the files changed
include something inside
lib/.Requires npm/benchmarks#30 to be merged in the
benchmark repo to allow
issue_commentas a valid trigger.