Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node in and fallback to PATH if not found #4778

Merged
merged 1 commit into from Apr 20, 2022
Merged

Use node in and fallback to PATH if not found #4778

merged 1 commit into from Apr 20, 2022

Conversation

elibus
Copy link
Contributor

@elibus elibus commented Apr 19, 2022

Contrary to npm, npx does not check $basedir/node and fallbacks to node if $basedir/node is not found.

This pull request align the behaviour of npx with npm.

@elibus elibus requested a review from a team as a code owner April 19, 2022 21:20
wraithgar
wraithgar approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@lukekarrys lukekarrys merged commit a677f49 into npm:latest Apr 20, 2022
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
Merged
@npm-robot npm-robot mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elibus @wraithgar @lukekarrys