Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: npmlog@7.0.1 #5717

Merged
merged 1 commit into from
Oct 19, 2022
Merged

deps: npmlog@7.0.1 #5717

merged 1 commit into from
Oct 19, 2022

Conversation

lukekarrys
Copy link
Contributor

Previously, npmlog was attempting to enable the progress bar even when
logs were paused. This displayed the most recent log (most often an
error) for the rest of the process.

Fixes #4527

Previously, `npmlog` was attempting to enable the progress bar even when
logs were paused. This displayed the most recent log (most often an
error) for the rest of the process.

Fixes #4527
@lukekarrys lukekarrys requested a review from a team as a code owner October 19, 2022 06:03
@lukekarrys
Copy link
Contributor Author

An easy way to reproduce this issue is when running workspace scripts with -ws. If this first script fails and the second one has a delay, it will display the progress bar covering some of the output.

With the following packages, the display bug will appear when running npm test -ws.

> npm pkg get -iwr -ws
{
  "workspaces": {
    "name": "workspaces",
    "version": "1.0.0",
    "workspaces": [
      "ws1",
      "ws2"
    ]
  },
  "ws1": {
    "name": "ws1",
    "version": "1.0.0",
    "scripts": {
      "test": "sleep 1 && echo error && exit 1"
    }
  },
  "ws2": {
    "name": "ws2",
    "version": "1.0.0",
    "scripts": {
      "test": "sleep 1 && echo success"
    }
  }
}

Here is a screenshot of the output before and after this change: Screen Shot 2022-10-18 at 10 01 24 PM

@lukekarrys lukekarrys merged commit dc16e73 into latest Oct 19, 2022
@lukekarrys lukekarrys deleted the deps/npmlog-7.0.1 branch October 19, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm produces "timing" log output when "npm start"
2 participants