Update various dev dependencies #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/no-make
branch
from
bac1918
to
b705362
Compare
lukekarrys
force-pushed
the
lk/doc-deps
branch
from
f5971df
to
30c4466
Compare
lukekarrys
force-pushed
the
lk/doc-deps
branch
from
30c4466
to
ccbdb0b
Compare
|
Marked as a draft since this should go after #5739. Once that is merged this will be marked as ready for review. Also note that this should be rebased. |
We will be updating to mdx@2 soon which is esm only, but built in to Gatsby. Due to the new documentation build process here and in `npm/documentation`, there is much less need for us to verify all our docs here. Therefore, it is best to remove this dependency now to avoid needing to update it here at the same time as the docs site.
This moves all the dependencies of the `docs/` workspace to dev deps. I had originally moved them out of devDeps as part of #5309, but this seems to go against the grain of other tooling. We would have to special case both `audit` and `licensee` to run on a custom subset of our dependency tree. Maybe one day when all tools can be piped the output of an `npm query` this will be possible. It would be nice if we could only audit dependencies that are bundled as part of the CLI. But for now it's easier to move these to devDeps and then reinstall only the docs workspace after pruning during the publish step.
lukekarrys
force-pushed
the
lk/doc-deps
branch
from
ccbdb0b
to
ac75699
Compare
|
Rebased against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: @npmcli/temlate-oss@4.8.0
chore: move doc deps to dev
This moves all the dependencies of the
docs/workspace to dev deps. Ihad originally moved them out of devDeps as part of feat: rewrite docs generation #5309, but this
seems to go against the grain of other tooling. We would have to special
case both
auditandlicenseeto run on a custom subset of ourdependency tree.
Maybe one day when all tools can be piped the output of an
npm querythis will be possible. It would be nice if we could only audit
dependencies that are bundled as part of the CLI.
But for now it's easier to move these to devDeps and then reinstall only
the docs workspace after pruning during the publish step.
chore: licensee@9.0.0
chore: remove mdx from docs build
We will be updating to mdx@2 soon which is esm only, but built in to
Gatsby. Due to the new documentation build process here and in
npm/documentation, there is much less need for us to verify all ourdocs here. Therefore, it is best to remove this dependency now to avoid
needing to update it here at the same time as the docs site.