chore(release): call release-integration workflow from release #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Jan 24, 2023
lukekarrys
approved these changes
Jan 24, 2023
| @@ -12,21 +15,6 @@ on: | |||
| required: true | |||
|
|
|||
| jobs: | |||
There was a problem hiding this comment.
This is a great! For a next step I think we could put other jobs here to run in parallel with the node-integration like sending the node PR and updating the docs.
Then once the node-integration suite is dialed in we can make the node PR job depend on that and include a link to the workflow run in the PR body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since our releases are created from within an action by release-please the release-integration workflow doesn't get triggered. in order to make it work, we instead use
workflow_callfrom within the release.ymldraft as this depends on npm/template-oss#269 being merged and published before it will workthis pr now updates @npmcli/template-oss and is ready for review