docs: Update description for publish --provenance flag #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
changed the title
wraithgar
reviewed
Apr 19, 2023
lib/utils/config/definitions.js
Outdated
| @@ -1624,7 +1624,7 @@ define('provenance', { | |||
| default: false, | |||
| type: Boolean, | |||
| description: ` | |||
| Indicates that a provenance statement should be generated. | |||
| When you publish from a supported cloud CI/CD system, this will publicly establish where the package was built and published from. | |||
There was a problem hiding this comment.
Suggested change
| When you publish from a supported cloud CI/CD system, this will publicly establish where the package was built and published from. | |
| When you publish from a supported cloud CI/CD system, this will publicly | |
| establish where the package was built and published from. |
|
|
Signed-off-by: Philip Harrison <philip@mailharrison.com>
Merged
ljharb
reviewed
Apr 19, 2023
| @@ -1624,7 +1624,8 @@ define('provenance', { | |||
| default: false, | |||
| type: Boolean, | |||
| description: ` | |||
| Indicates that a provenance statement should be generated. | |||
| When publishing from a supported cloud CI/CD system, the package will be | |||
| publicly linked to where it was built and published from. | |||
There was a problem hiding this comment.
probably we don't want to end sentences with a preposition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs: https://docs.npmjs.com/cli/v9/commands/npm-publish?v=true#provenance