Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better color support detection #6556

Merged
merged 1 commit into from Jun 15, 2023
Merged

fix: better color support detection #6556

merged 1 commit into from Jun 15, 2023

Conversation

lukekarrys
Copy link
Member

@lukekarrys lukekarrys commented Jun 14, 2023

No description provided.

@lukekarrys lukekarrys marked this pull request as ready for review June 14, 2023 22:34
@lukekarrys lukekarrys changed the title lk/tap color fix: make tests work without tap color config Jun 14, 2023
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jun 14, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 34.233 ±1.29 16.923 ±0.15 16.350 ±0.00 19.183 ±0.46 2.778 ±0.04 2.763 ±0.03 2.283 ±0.08 11.354 ±0.02 2.215 ±0.02 3.450 ±0.18 0.380 ±0.02 0.411 ±0.00
#6556 36.847 ±3.94 17.236 ±0.04 16.656 ±0.05 19.200 ±0.24 2.756 ±0.01 2.730 ±0.06 2.243 ±0.02 11.569 ±0.09 2.232 ±0.05 3.324 ±0.06 0.385 ±0.00 0.431 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 26.498 ±1.85 13.293 ±0.06 12.720 ±0.03 13.496 ±0.47 2.359 ±0.01 2.422 ±0.03 2.145 ±0.02 8.602 ±0.04 2.069 ±0.01 2.872 ±0.05 0.367 ±0.01 0.407 ±0.00
#6556 25.670 ±1.17 13.233 ±0.09 12.941 ±0.05 13.834 ±0.41 2.427 ±0.03 2.417 ±0.00 2.191 ±0.01 8.723 ±0.02 2.073 ±0.02 2.946 ±0.02 0.387 ±0.00 0.438 ±0.00

@lukekarrys lukekarrys changed the title fix: make tests work without tap color config fix: better color support detection Jun 15, 2023
@lukekarrys lukekarrys merged commit d980405 into latest Jun 15, 2023
27 checks passed
@lukekarrys lukekarrys deleted the lk/tap-color branch June 15, 2023 16:07
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants