Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smaller v10 breaks #6641

Merged
merged 8 commits into from Jul 26, 2023
Merged

smaller v10 breaks #6641

merged 8 commits into from Jul 26, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jul 13, 2023

  • fix: remove metric-registry config
  • fix: remove "tmp" config
  • fix: remove "hashAlgorithm" from flatOptions
  • chore: test fixes for breaking changes in workspaces
  • fix: stop retrying on 409 conflict
  • chore: remove lodash.clonedeep
  • fix: remove implicit if-present logic from run-script workspaces
  • fix: remove "ci-name" config

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jul 13, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 50.804 ±0.84 20.579 ±0.05 19.915 ±0.02 22.910 ±0.64 3.262 ±0.02 3.303 ±0.02 2.814 ±0.09 13.579 ±0.07 2.755 ±0.00 4.092 ±0.13 0.488 ±0.01 0.533 ±0.01
#6641 48.674 ±3.34 21.208 ±0.30 20.334 ±0.24 22.959 ±0.15 3.300 ±0.07 3.348 ±0.01 2.773 ±0.04 13.874 ±0.02 2.772 ±0.07 4.145 ±0.04 0.474 ±0.01 0.539 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 34.731 ±0.91 16.162 ±0.24 15.820 ±0.03 16.719 ±0.37 3.073 ±0.06 3.058 ±0.05 2.805 ±0.00 10.530 ±0.15 2.629 ±0.06 3.665 ±0.09 0.481 ±0.02 0.540 ±0.01
#6641 33.932 ±0.59 16.157 ±0.02 15.809 ±0.10 16.901 ±0.15 2.999 ±0.03 2.994 ±0.01 2.793 ±0.00 10.600 ±0.04 2.604 ±0.01 3.621 ±0.04 0.469 ±0.01 0.534 ±0.00

BREAKING CHANGE: the hard-coded "metrics-registry" config has been
removed.

This is not used by npm at all, and is also not used by any of the npm
modules that consume config.  npm does not send data to any metrics
server.
BREAKING CHANGE: the unused "tmp" config has been removed
BREAKING CHANGE: the hard-coded "hashAlgorithm" value is no longer being
passed through flatOptions

Nothing in npm is using this.
BREAKING CHANGE: libnpmpublish will no longer attempt a single automatic
retry on 409 responses during publish.
BREAKING CHANGE: npm no longer treats missing scripts as a special case
in workspace mode.  Use `if-present` to ignore missing scripts.
BREAKING CHANGE: the "ci-name" config has been removed

The "ci" portion of the default "user-agent" will now only be derived
from the environment and can not be manually overridden.
@lukekarrys lukekarrys marked this pull request as ready for review July 26, 2023 18:42
@lukekarrys lukekarrys requested a review from a team as a code owner July 26, 2023 18:42
@lukekarrys lukekarrys merged commit e0d3edd into latest Jul 26, 2023
65 checks passed
@lukekarrys lukekarrys deleted the gar/small-v10-breaks branch July 26, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants