Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] tap-snapshots in the npm package #461

Closed
XhmikosR opened this issue Nov 10, 2019 · 0 comments
Closed

[BUG] tap-snapshots in the npm package #461

XhmikosR opened this issue Nov 10, 2019 · 0 comments

Comments

@XhmikosR
Copy link
Contributor

What / Why

n/a

When

  • n/a

Where

  • n/a

How

Current Behavior

  • n/a

Steps to Reproduce

  • n/a

Expected Behavior

  • n/a

Who

  • n/a

References

  • n/a

I'm seeing this in npm v6.13.0: there's a tap-snapshots folder with 2 files. I'm not sure if those are needed in the tarball, so I thought I'd mention it. Also, it seems there are many seemingly unneeded files like .eslintrc, .travis.yml etc.
ruyadorno added a commit to ruyadorno/cli that referenced this issue Nov 11, 2019
@ruyadorno
fix: should not publish tap-snapshot folder
88361cc 
- Add `tap-snapshot` folder to `.npmignore`
- Fixes npm#461
@ruyadorno ruyadorno mentioned this issue Nov 11, 2019
Closed
claudiahdz pushed a commit that referenced this issue Nov 13, 2019
@ruyadorno @claudiahdz
fix: should not publish tap-snapshot folder
2d5c78c 
- Add `tap-snapshot` folder to `.npmignore`
- Fixes #461

PR-URL: #471
Credit: @ruyadorno
Close: #471
Reviewed-by: @claudiahdz
@XhmikosR XhmikosR mentioned this issue Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: should not publish tap-snapshot folder ruyadorno/cli
1 participant
@XhmikosR