fix: remove polyfills which are out of range of our engines #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this a |
|
Yeah, it felt like a blurry line here to me. The feature is that it's not going to use polyfills anymore for those methods 😄 (which would only happen if you're running it outside of engines support). That didn't feel like a fix to me. |
lukekarrys
force-pushed
the
lk/rm-old-polyfills
branch
from
d7aeaaf
to
922676f
Compare
lukekarrys
changed the title
|
Switched commit and PR title to |
lukekarrys
force-pushed
the
lk/rm-old-polyfills
branch
2 times, most recently
from
71e562d
to
6fb1fe8
Compare
The polyfills removed are: - file-url-to-path.js - mkdir.js
lukekarrys
force-pushed
the
lk/rm-old-polyfills
branch
from
6fb1fe8
to
5950a8a
Compare
wraithgar
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polyfills removed are: