move 'sort' to the object, not the props

npm · Mar 27, 2012 · b6f3dd3 · b6f3dd3
1 parent d175163
commit b6f3dd3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/dir-reader.js b/lib/dir-reader.js
@@ -30,6 +30,10 @@ function DirReader (props) {
   me._paused = false
   me._length = -1
 
+  if (props.sort) {
+    this.sort = props.sort
+  }
+
   Reader.call(this, props)
 }
 
@@ -46,9 +50,8 @@ DirReader.prototype._getEntries = function () {
 
     function processEntries () {
       me._length = me.entries.length
-      // console.error("DR %s sort =", me.path, me.props.sort)
+      if (typeof me.sort === "function") {
-      if (typeof me.props.sort === "function") {
+        me.entries = me.entries.sort(me.sort.bind(me))
-        me.entries.sort(me.props.sort)
       }
       me._read()
     }