Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intersects with v0.0.0 and v0.0.0-0 #538

Merged
merged 2 commits into from Apr 10, 2023
Merged

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 6, 2023

Also fix options not being passed through from semver.intersects

Closes #521

@wraithgar wraithgar requested a review from a team as a code owner April 6, 2023 23:58
@wraithgar wraithgar requested review from lukekarrys and removed request for a team April 6, 2023 23:58
@wraithgar
Copy link
Member Author

This can't land before #535 since that removes the dead code that is causing coverage failures here.

classes/comparator.js Outdated Show resolved Hide resolved
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, good bug fix and so much more readable!

Also fix options not being passed through from semver.intersects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants