Also normalize GitHub URL's inside dependencies.

npm · Feb 11, 2014 · 005d0b6 · 005d0b6
1 parent 43e0a70
commit 005d0b6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/fixer.js b/lib/fixer.js
@@ -138,6 +138,11 @@ var fixer = module.exports = {
           this.warn(format(nonStringDependency, d, JSON.stringify(r)))
           delete data[deps][d]
         }
+        // "/" is not allowed as packagename for publishing, but for git-urls
+        // normalize shorthand-urls
+        if (githubUserRepo(data[deps][d])) {
+          data[deps][d] = githubUserRepo(data[deps][d])
+        }
       }, this)
     }, this)
   }

diff --git a/test/normalize.js b/test/normalize.js
@@ -196,6 +196,13 @@ tap.test("homepage field will set to github gist url if repository is a shorthan
   t.end()
 })
 
+tap.test("treat isaacs/node-graceful-fs as github repo in dependencies", function(t) {
+  var d = {dependencies: {"node-graceful-fs": "isaacs/node-graceful-fs"}}
+  normalize(d)
+  t.same(d.dependencies, {"node-graceful-fs": "git://github.com/isaacs/node-graceful-fs" })
+  t.end()
+});
+
 tap.test("deprecation warning for array in dependencies fields", function(t) {
   var a
   var warnings = []